[Pardus-devel] [review] review/applications/network/klibido

[Ismail Dönmez]

On Thursday 30 August 2007 17:52:27 Amine Chadly wrote:
> Hi !
> Request for merge of klibido (for contrib I guess ^^)
> Thanks in advance !

- db4 is in system.base, no need to add it as a dep.

- Instead of doing   <Path fileType="data">/usr/share</Path> write             
<Path fileType="data">/usr/share/foobar</Path> (give absolete paths), its 
easier to read and maintain

- Desktop file misses GenericName[] which is used in Pardus menu

- License says 2005-2007, it should be 2007 only

- Path to GPLv2 license text is wrong, its now showing GPLv3

- Leave a newline after autotools.install()

- Instead of pisitools.move(..) use pisitools.insinto

Regards,
ismail

-- 
Bize "yaşayalım" diye verilen hayatı yaşadık... // hayatberbat.com