[Pardus-devel] [Paketler] [review] desktop/kde/kplayer

[Ismail Dönmez]

On Thursday 05 July 2007 01:32:33 S.Çağlar Onur wrote:
> Hi;
>
> We are using pardus-devel mailing list for our non-turkish speaker
> developers/contributors package reviews, so adding that list to CC and
> dropping paketler one.
>
> 04 Tem 2007 Çar tarihinde, Ismail Dönmez şunları yazmıştı:
> > KPlayer package by  Jonas Pfenniger , please review.
>
> actions.py:
> - No need to import autotools in actions.py
>
> kde.make("-f Makefile.dist")
>
> can be used.
>
> pspec.xml:
> - No need to depend qt, cause kdebase already depends it @
> BuildDependencies
>
> - No need to depend xorg-server, cause kdebase again already depends it @
> RuntimeDependencies
>
> - instead of writing all possible paths @ Files like following
>         <Files>
>             <Path fileType="executable">/usr/kde/3.5/bin</Path>
>             <Path fileType="library">/usr/kde/3.5/lib</Path>
>             <Path fileType="data">/usr/kde/3.5/share/applications</Path>
>             <Path fileType="data">/usr/kde/3.5/share/apps</Path>
>             <Path fileType="doc">/usr/kde/3.5/share/doc</Path>
>             <Path fileType="data">/usr/kde/3.5/share/icons</Path>
>             <Path fileType="localedata">/usr/kde/3.5/share/locale</Path>
>             <Path fileType="data">/usr/kde/3.5/share/services</Path>
>         </Files>
>
> that one
>
>         <Files>
>             <Path fileType="executable">/usr/kde/3.5/bin</Path>
>             <Path fileType="library">/usr/kde/3.5/lib</Path>
>             <Path fileType="data">/usr/kde/3.5/share/</Path>
>             <Path fileType="doc">/usr/kde/3.5/share/doc</Path>
>             <Path fileType="localedata">/usr/kde/3.5/share/locale</Path>
>         </Files>
>
> can be used.
>
> ACK (after these corrected)

Fixed, also removed mplayer from BuildDependencies since it can't be a build 
dep.

/ismail

-- 
Perfect is the enemy of good
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://liste.pardus.org.tr/pardus-devel/attachments/20070705/acb7a868/attachment-0001.pgp