[Pardus-devel] [review] review/applications/network/klibido

Eren Türkay turkay.eren at gmail.com
Sat Sep 15 19:21:30 EEST 2007


On Friday 31 August 2007 03:40:03 Ismail Dönmez wrote:
> - db4 is in system.base, no need to add it as a dep.
>
> - Instead of doing   <Path fileType="data">/usr/share</Path> write        
>     <Path fileType="data">/usr/share/foobar</Path> (give absolete paths),
> its easier to read and maintain
>
> - Desktop file misses GenericName[] which is used in Pardus menu
>
> - License says 2005-2007, it should be 2007 only
>
> - Path to GPLv2 license text is wrong, its now showing GPLv3
>
> - Leave a newline after autotools.install()
>
> - Instead of pisitools.move(..) use pisitools.insinto
>
> Regards,
> ismail

After having fixed uudeview, klibido is compiled and works fine. Also those 
mistakes have been fixed. ACK please? I will add it to Contrib


More information about the Pardus-devel mailing list