[Pardus-devel] [review] review/applications/network/klibido

[Mustafa Günay]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday 15 September 2007 19:21:30 Eren Türkay wrote:
> On Friday 31 August 2007 03:40:03 Ismail Dönmez wrote:
> > - db4 is in system.base, no need to add it as a dep.
> >
> > - Instead of doing   <Path fileType="data">/usr/share</Path> write      
> >   <Path fileType="data">/usr/share/foobar</Path> (give absolete paths),
> > its easier to read and maintain
> >
> > - Desktop file misses GenericName[] which is used in Pardus menu
> >
> > - License says 2005-2007, it should be 2007 only
> >
> > - Path to GPLv2 license text is wrong, its now showing GPLv3
> >
> > - Leave a newline after autotools.install()
> >
> > - Instead of pisitools.move(..) use pisitools.insinto
> >
> > Regards,
> > ismail
>
> After having fixed uudeview, klibido is compiled and works fine. Also those
> mistakes have been fixed. ACK please? I will add it to Contrib
> _______________________________________________
> Pardus-devel mailing list
> Pardus-devel at pardus.org.tr
> http://liste.uludag.org.tr/mailman/listinfo/pardus-devel

OK for me

Sir İsmail (cartman) Dönmez  re-review pls

- -- 
Mustafa GÜNAY

asato ma sad gamaya (From delusion lead me to truth)
tamaso ma jyotir gamaya (From darkness lead me to light)
mrutyor ma amrtam gamaya (From death lead me to immortality)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4 (GNU/Linux)

iD8DBQFG/vwoP7nwX0e/pPYRAir3AJ9WWYNt/pigZdRgvM47bBFzdqoQ/gCeKIDb
/g7nwMdar4C9s6W8R1L9S54=
=Fbd0
-----END PGP SIGNATURE-----